Skip to content

Add support for App Check tokens in logging #9310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2025
Merged

Add support for App Check tokens in logging #9310

merged 5 commits into from
Oct 15, 2025

Conversation

mghaznav
Copy link

@mghaznav mghaznav commented Oct 9, 2025

Discussion

Add support for App Check tokens with. If App Check has been initialized in the app, an app check token header will be included with the logging request on client-side.

Testing

Unit tested, manually tested

API Changes

N/A

@mghaznav mghaznav requested review from a team as code owners October 9, 2025 20:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c0ebfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 9, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/telemetry

    TypeBase (70e7a5f)Merge (daf259c)Diff
    browser5.94 kB6.39 kB+446 B (+7.5%)
    main6.69 kB6.51 kB-184 B (-2.7%)
    module5.94 kB6.39 kB+446 B (+7.5%)

  • firebase

    TypeBase (70e7a5f)Merge (daf259c)Diff
    firebase-telemetry.js85.9 kB73.5 kB-12.3 kB (-14.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tTiFhuVpnH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 9, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/telemetry

    • captureError

      Size

      TypeBase (70e7a5f)Merge (daf259c)Diff
      size3.57 kB3.84 kB+272 B (+7.6%)
      size-with-ext-deps65.7 kB54.7 kB-11.0 kB (-16.7%)

      Dependency

      TypeBase (70e7a5f)Merge (daf259c)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (daf259c)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

    • flush

      Size

      TypeBase (70e7a5f)Merge (daf259c)Diff
      size2.97 kB3.24 kB+272 B (+9.2%)
      size-with-ext-deps64.4 kB53.4 kB-11.0 kB (-17.0%)

      Dependency

      TypeBase (70e7a5f)Merge (daf259c)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (daf259c)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

    • getTelemetry

      Size

      TypeBase (70e7a5f)Merge (daf259c)Diff
      size2.97 kB3.25 kB+272 B (+9.1%)
      size-with-ext-deps71.5 kB60.5 kB-11.0 kB (-15.3%)

      Dependency

      TypeBase (70e7a5f)Merge (daf259c)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (daf259c)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

    • nextOnRequestError

      Size

      TypeBase (70e7a5f)Merge (daf259c)Diff
      size3.92 kB4.19 kB+272 B (+6.9%)
      size-with-ext-deps73.1 kB62.1 kB-11.0 kB (-15.0%)

      Dependency

      TypeBase (70e7a5f)Merge (daf259c)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (daf259c)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kucHkJQXnE.html

hsubox76
hsubox76 reviewed Oct 10, 2025
View reviewed changes
@mghaznav mghaznav merged commit 2c5a4f7 into telemetry Oct 15, 2025
45 of 48 checks passed
@mghaznav mghaznav deleted the telemetry-secure branch October 15, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@andrewbrook andrewbrook andrewbrook approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mghaznav @google-oss-bot @hsubox76 @andrewbrook